Skip to content

Storages: Deprecated libclara for normal build #10325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 4, 2025
Merged

Storages: Deprecated libclara for normal build #10325

merged 3 commits into from
Aug 4, 2025

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Aug 4, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10324

Problem Summary:

What is changed and how it works?

Storages: Deprecated libclara for normal build
  * Add `ENABLE_CLARA` and disable it by default in normal build
  * Exclude the files under `dbms/src/Storages/DeltaMerge/Index/FullTextIndex` when `ENABLE_CLARA` is disabled

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    Both debug and release build in local env is success
# Debug build
>  ninja -j 32 tiflash gtests_dbms gtests_libcommon
>  ./dbms/src/Server/tiflash version
TiFlash
Release Version: v9.0.0-beta.2.pre-15-g33e88b3667
Edition:         Community
Git Commit Hash: 33e88b36675ec72288bda52b5c296e3f55789d43
Git Branch:      deprecated_clara
UTC Build Time:  2025-08-04 04:57:48
Enable Features: jemalloc sm4(GmSSL) mem-profiling failpoints avx2 avx512 unwind hnsw.l2=skylake hnsw.cosine=skylake vec.l2=skylake vec.cos=skylake
Profile:         DEBUG
Compiler:        clang++ 17.0.6

Raft Proxy
Git Commit Hash:   3e325b2b9b30e396c846bfeb97a690d070b84087
Git Commit Branch: HEAD
UTC Build Time:    ""   
Rust Version:      rustc 1.77.0-nightly (89e2160c4 2023-12-27)
Storage Engine:    tiflash
Prometheus Prefix: tiflash_proxy_
Profile:           debug
Enable Features:   external-jemalloc portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine openssl-vendored

# Release build
> ninja -j 32 tiflash
>  ./dbms/src/Server/tiflash version
TiFlash
Release Version: v9.0.0-beta.2.pre-15-g33e88b3667
Edition:         Community
Git Commit Hash: 33e88b36675ec72288bda52b5c296e3f55789d43
Git Branch:      deprecated_clara
UTC Build Time:  2025-08-04 04:57:30
Enable Features: jemalloc sm4(GmSSL) mem-profiling avx2 avx512 unwind hnsw.l2=skylake hnsw.cosine=skylake vec.l2=skylake vec.cos=skylake
Profile:         RelWithDebInfo
Compiler:        clang++ 17.0.6

Raft Proxy
Git Commit Hash:   3e325b2b9b30e396c846bfeb97a690d070b84087
Git Commit Branch: HEAD
UTC Build Time:    ""   
Rust Version:      rustc 1.77.0-nightly (89e2160c4 2023-12-27)
Storage Engine:    tiflash
Prometheus Prefix: tiflash_proxy_
Profile:           release
Enable Features:   external-jemalloc portable sse test-engine-kv-rocksdb test-engine-raft-raft-engine openssl-vendored
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Aug 4, 2025
@JaySon-Huang
Exclude include headers
a364935 
Signed-off-by: JaySon-Huang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 4, 2025
@JaySon-Huang
Copy link
Contributor Author

/run-sanitizer-test asan

@JaySon-Huang
Copy link
Contributor Author

/run-sanitizer-test asan

JaySon-Huang
JaySon-Huang commented Aug 4, 2025
View reviewed changes
dbms/src/Storages/DeltaMerge/Filter/PushDownExecutor.cpp
Comment on lines +212 to +219
#if ENABLE_CLARA
FTSQueryInfoPtr fts_query_info = nullptr;
if (dag_query->fts_query_info.query_type() != tipb::FTSQueryType::FTSQueryTypeInvalid)
fts_query_info = std::make_shared<tipb::FTSQueryInfo>(dag_query->fts_query_info);
#else
if (dag_query->fts_query_info.query_type() != tipb::FTSQueryType::FTSQueryTypeInvalid)
throw Exception("FTS query is not supported", ErrorCodes::NOT_IMPLEMENTED);
#endif
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throw exception when receive FTS query

@JaySon-Huang
Copy link
Contributor Author

/test pull-unit-next-gen

@JaySon-Huang
Copy link
Contributor Author

/test pull-integration-next-gen

@JaySon-Huang
Copy link
Contributor Author

/run-sanitizer-test tsan

@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 4, 2025

/hold

wait for the build tests.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2025
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 4, 2025

/hold

wait for the build tests.

buildings are passed on linux amd64 and arm64 platforms.

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2025
CalvinNeo
CalvinNeo approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 4, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CalvinNeo,Lloyd-Pottiger]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 4, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-04 10:01:46.613159636 +0000 UTC m=+262416.755920821: ☑️ agreed by CalvinNeo.
  • 2025-08-04 10:02:18.729260913 +0000 UTC m=+262448.872022088: ☑️ agreed by Lloyd-Pottiger.

@ti-chi-bot ti-chi-bot bot merged commit fc932c9 into pingcap:master Aug 4, 2025
8 checks passed
@JaySon-Huang JaySon-Huang deleted the deprecated_clara branch August 4, 2025 12:31
@JaySon-Huang
Copy link
Contributor Author

/cherry-pick release-nextgen-20250815

@JaySon-Huang
Copy link
Contributor Author

/cherry-pick release-9.0-beta.2

@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created to branch release-nextgen-20250815: #10329.

In response to this:

/cherry-pick release-nextgen-20250815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 4, 2025
Merged
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 4, 2025
@JaySon-Huang @ti-chi-bot
This is an automated cherry-pick of pingcap#10325
756a823 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 4, 2025
Open
12 tasks
@ti-chi-bot
Copy link
Member

@JaySon-Huang: new pull request created to branch release-9.0-beta.2: #10330.
But this PR has conflicts, please resolve them!

In response to this:

/cherry-pick release-9.0-beta.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Aug 5, 2025
@ti-chi-bot @JaySon-Huang
Storages: Deprecated libclara for normal build (#10325) (#10329)
d936f1e 
close #10324

Storages: Deprecated libclara for normal build
  * Add `ENABLE_CLARA` and disable it by default in normal build
  * Exclude the files under `dbms/src/Storages/DeltaMerge/Index/FullTextIndex` when `ENABLE_CLARA` is disabled

Signed-off-by: JaySon-Huang <[email protected]>

Co-authored-by: JaySon-Huang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building with libclara is broken
5 participants
@JaySon-Huang @wuhuizuo @ti-chi-bot @CalvinNeo @Lloyd-Pottiger