-
Notifications
You must be signed in to change notification settings - Fork 415
fix data race of LocalAdmissionController (#10332) #10342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-8.1
Are you sure you want to change the base?
fix data race of LocalAdmissionController (#10332) #10342
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@guo-shaoge This PR has conflicts, I have hold it. |
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: guo-shaoge <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: solotzg, wshwsh12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
this pr has been tagged as |
This is an automated cherry-pick of #10332
What problem does this PR solve?
Issue Number: close #10331
Problem Summary:
What is changed and how it works?
keyspace_resource_groups
current_tick/cur_tick_end
.endRequest
when got error in the logic of handling GAC resp. Otherwise this rg will enter degrade mode, and it will not acquire any tokens from GAC forDEGRADE_MODE_DURATION
seconds (120s)Check List
Tests
Side effects
Documentation
Release note