Skip to content

Fix cte concurrent unit test #10377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2025
Merged

Fix cte concurrent unit test #10377

merged 1 commit into from
Aug 28, 2025

Conversation

xzhangxian1008
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 commented Aug 28, 2025 •
edited by JaySon-Huang
Loading

What problem does this PR solve?

Issue Number: close #10373
Problem Summary:

What is changed and how it works?

We introduce a new variable to record how many threads have exited so that we can ensure that all blocks have been pushed into queue before `notifyEOF` is called.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix flaky cte concurrent unit test

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 28, 2025
windtalker
windtalker approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 28, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 28, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-28 03:11:05.361764429 +0000 UTC m=+409757.239595383: ☑️ agreed by windtalker.
  • 2025-08-28 03:13:43.344526608 +0000 UTC m=+409915.222357562: ☑️ agreed by JaySon-Huang.

@ti-chi-bot ti-chi-bot bot merged commit c077d8b into pingcap:master Aug 28, 2025
7 checks passed
@xzhangxian1008 xzhangxian1008 deleted the fix-10373 branch August 28, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky test TestCTE.Concurrent
3 participants
@xzhangxian1008 @windtalker @JaySon-Huang