Skip to content

Pipeline: refactor the extra time calculation in explain analyze #8987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 8, 2024
Merged

Pipeline: refactor the extra time calculation in explain analyze #8987

merged 11 commits into from
May 8, 2024

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Apr 25, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #8962

Problem Summary:

What is changed and how it works?

  1. refactor the wait_for_notify_time of operator by introducing PipelineExec::wait_for_notify and use Operator::notify to collect the waiting_for_notify time
  2. Distribute the pending time evenly across all operators.
  3. add exec_context.getQueryProfileInfo().toJson() to mpp tracing log

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 25, 2024
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 25, 2024

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 25, 2024

/cc @windtalker @gengliqi

@ti-chi-bot ti-chi-bot bot requested review from gengliqi and windtalker April 25, 2024 10:18
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 25, 2024

/cc @JinheLin @JaySon-Huang

@ti-chi-bot ti-chi-bot bot requested review from JaySon-Huang and JinheLin April 25, 2024 10:18
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 25, 2024

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 25, 2024

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented May 6, 2024

/test all

@SeaRise SeaRise mentioned this pull request May 6, 2024
Merged
12 tasks
JaySon-Huang
JaySon-Huang approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 7, 2024
windtalker
windtalker approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 8, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JaySon-Huang,windtalker]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-07 05:41:22.513363873 +0000 UTC m=+940636.270499653: ☑️ agreed by JaySon-Huang.
  • 2024-05-08 02:48:38.604774863 +0000 UTC m=+1016672.361910436: ☑️ agreed by windtalker.

@ti-chi-bot ti-chi-bot bot merged commit 6129d97 into pingcap:master May 8, 2024
@SeaRise SeaRise deleted the fix_extra_time branch May 8, 2024 06:48
@ti-chi-bot ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 15, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #9047.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request May 15, 2024
@SeaRise @ti-chi-bot
This is an automated cherry-pick of pingcap#8987
c150b2c 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request May 15, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request May 16, 2024
@ti-chi-bot
Pipeline: refactor the extra time calculation in explain analyze (#8987…
acdbe72 
…) (#9047)

close #8962
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
@ti-chi-bot @JaySon-Huang
Pipeline: refactor the extra time calculation in explain analyze (pin…
053809e 
…gcap#8987) (pingcap#9047)

close pingcap#8962
@windtalker windtalker added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Aug 21, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #9340.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 21, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Sep 4, 2024
@ti-chi-bot @SeaRise @JaySon-Huang
Pipeline: refactor the extra time calculation in explain analyze (#8987…
0d9d397 
…) (#9340)

close #8962

Co-authored-by: SeaRise <[email protected]>
Co-authored-by: JaySon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@gengliqi gengliqi Awaiting requested review from gengliqi

@JinheLin JinheLin Awaiting requested review from JinheLin

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TiFlash table scan performance gain after mpp column prune enhancement
4 participants
@SeaRise @ti-chi-bot @windtalker @JaySon-Huang