Support query argument redaction in DM logging

[michaelmdeng]

Is your feature request related to a problem?

When DM logs queries, either with debug logging for all queries, or when encountering errors with warning/error logging, it logs the entire text of the query with arguments. This risks logging sensitive data.

For example, many of the log lines in https://github.com/pingcap/tiflow/blob/master/dm/pkg/conn/baseconn.go will log (truncated) full queries and arguments

Describe the feature you'd like

Configuration, similar to tidb log redaction, that will redact sensitive arguments from queries when DM logs them.

Describe alternatives you've considered

Since they are logged at all possible log levels, no alternative but turning off logging entirely.

Teachability, Documentation, Adoption, Migration Strategy

N/A

[db-will]

Hey @michaelmdeng , I want to follow up on this issue. Should we redact the SQL query, or is redacting the query arguments sufficient?

[lance6716]

There are still some places that forget to proactively use redact function.

[db-will]

@lance6716 could you point out a few places that we might need to redact sensitive info? thanks

[lance6716]

like

tiflow/dm/syncer/dbconn/db.go

Line 249 in 8e3b63a

zap.String("arguments", utils.TruncateInterface(args, -1)),

[db-will]

@lance6716 tried to find similar pattern as you presented, didn't find any other similar lines that print out query arguments. i create a update pr.