Skip to content

codec(ticdc): canal-json unit test embrace schema test helper #10911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2024
Merged

codec(ticdc): canal-json unit test embrace schema test helper #10911

merged 1 commit into from
Apr 24, 2024

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #10910

What is changed and how it works?

  • use schema test helper to build the events

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 16, 2024
@3AceShowHand
Copy link
Contributor Author

/retest

@codecov Codecov
Copy link

codecov bot commented Apr 16, 2024 •
edited
Loading

Codecov Report

Merging #10911 (963edff) into master (344a5d8) will increase coverage by 0.1384%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
Components Coverage Δ
cdc 61.8966% <ø> (+0.2153%) ⬆️
dm 51.2777% <ø> (+0.0464%) ⬆️
engine 63.4232% <ø> (+0.0353%) ⬆️
Flag Coverage Δ
unit 57.5287% <ø> (+0.1384%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10911        +/-   ##
================================================
+ Coverage   57.3902%   57.5287%   +0.1384%     
================================================
  Files           851        851                
  Lines        125145     125506       +361     
================================================
+ Hits          71821      72202       +381     
+ Misses        47929      47908        -21     
- Partials       5395       5396         +1

@3AceShowHand
Copy link
Contributor Author

/retest

6 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 17, 2024
@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 17, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-17 06:18:10.425944277 +0000 UTC m=+405309.536990726: ☑️ agreed by CharlesCheung96.
  • 2024-04-17 06:25:44.677952899 +0000 UTC m=+405763.788999342: ☑️ agreed by asddongmen.

@3AceShowHand
Copy link
Contributor Author

/retest

5 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

6 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/test dm-compatibility-test

@3AceShowHand
Copy link
Contributor Author

/retest

10 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

2 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 49d3c07 into pingcap:master Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@lidezhu lidezhu Awaiting requested review from lidezhu

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

@hongyunyan hongyunyan Awaiting requested review from hongyunyan

+1 more reviewer

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

open-protocol unit test embrace schema test helper
3 participants
@3AceShowHand @asddongmen @CharlesCheung96