Skip to content

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #11163

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 22, 2024
@3AceShowHand 3AceShowHand requested review from GMHDBJD and lance6716 May 22, 2024 07:47
@3AceShowHand
Copy link
Contributor Author

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/retest

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 29.08199% with 1012 lines in your changes are missing coverage. Please review.

Project coverage is 57.2339%. Comparing base (4d89c24) to head (9f91f06).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.2372% <29.0819%> (-0.7555%) ⬇️
dm 51.2001% <ø> (+0.0010%) ⬆️
engine 63.4091% <ø> (+0.0211%) ⬆️
Flag Coverage Δ
unit 57.2339% <29.0819%> (-0.3174%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11164        +/-   ##
================================================
- Coverage   57.5512%   57.2339%   -0.3174%     
================================================
  Files           854        859         +5     
  Lines        126112     127538      +1426     
================================================
+ Hits          72579      72995       +416     
- Misses        48143      49128       +985     
- Partials       5390       5415        +25     

@3AceShowHand 3AceShowHand added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 23, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 23, 2024
Copy link
Contributor

ti-chi-bot bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 23, 2024
Copy link
Contributor

ti-chi-bot bot commented May 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-23 07:57:42.241285862 +0000 UTC m=+2331215.998421428: ☑️ agreed by lance6716.
  • 2024-05-23 08:05:01.603913738 +0000 UTC m=+2331655.361049311: ☑️ agreed by asddongmen.

@ti-chi-bot ti-chi-bot bot merged commit 9515070 into pingcap:master May 23, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11168.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request May 23, 2024
@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-8.1

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jul 29, 2024
@ti-chi-bot
Copy link
Member

@3AceShowHand: new pull request created to branch release-8.1: #11420.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move diff package from tidb-tools to tiflow repo
4 participants