Skip to content

Conversation

hongyunyan
Copy link
Collaborator

@hongyunyan hongyunyan commented Jun 5, 2024

What problem does this PR solve?

Issue Number: close #11009

What is changed and how it works?

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
  1. create changefeed.
  2. set global tidb_enable_fast_create_table=on; for the upstream tidb'
  3. concurrently create 1000 tables in upstream, and insert data
  4. check the tables and data in the downstream tidb
    image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 5, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 6, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 6, 2024
@hongyunyan hongyunyan changed the title [WIP]ddl(ticdc): support batch create table ddl ddl(ticdc): support batch create table ddl Jun 6, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 57.6352%. Comparing base (971bfcd) to head (d926d56).
Report is 6 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.4477% <0.0000%> (-0.0287%) ⬇️
dm 51.1910% <ø> (+0.0140%) ⬆️
engine 63.4091% <ø> (+0.0141%) ⬆️
Flag Coverage Δ
unit 57.6352% <0.0000%> (-0.0024%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11262        +/-   ##
================================================
- Coverage   57.6375%   57.6352%   -0.0024%     
================================================
  Files           850        850                
  Lines        126055     126211       +156     
================================================
+ Hits          72655      72742        +87     
- Misses        47998      48061        +63     
- Partials       5402       5408         +6     

@hongyunyan
Copy link
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 9, 2024
@hongyunyan
Copy link
Collaborator Author

/retest

Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-09 00:32:33.84031735 +0000 UTC m=+251907.893629268: ☑️ agreed by sdojjy.
  • 2024-06-12 09:37:41.907196188 +0000 UTC m=+543815.960508113: ☑️ agreed by CharlesCheung96.

@hongyunyan
Copy link
Collaborator Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ticdc: Support Batch Create DDL type
3 participants