Skip to content

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Jul 18, 2024

What problem does this PR solve?

Issue Number: close #11806

What is changed and how it works?

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)
    image

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 18, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 18, 2024
@CharlesCheung96
Copy link
Contributor Author

/test cdc-integration-mysql-test

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2024
@CharlesCheung96
Copy link
Contributor Author

/test cdc-integration-mysql-test

@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review July 24, 2024 02:29
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2024
@CharlesCheung96
Copy link
Contributor Author

/retest

1 similar comment
@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.4534%. Comparing base (482fd8e) to head (594d180).
Report is 83 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.2047% <ø> (+0.0086%) ⬆️
dm 51.0214% <ø> (-0.1947%) ⬇️
engine 63.4020% <ø> (+0.0494%) ⬆️
Flag Coverage Δ
unit 57.4534% <ø> (-0.0647%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11407        +/-   ##
================================================
- Coverage   57.5181%   57.4534%   -0.0647%     
================================================
  Files           849        849                
  Lines        126355     126318        -37     
================================================
- Hits          72677      72574       -103     
- Misses        48263      48339        +76     
+ Partials       5415       5405        -10     

Copy link
Contributor

ti-chi-bot bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-09 09:44:21.48299467 +0000 UTC m=+604391.350093757: ☑️ agreed by hongyunyan.
  • 2024-11-27 04:20:33.152061609 +0000 UTC m=+610220.771716124: ☑️ agreed by sdojjy.

@ti-chi-bot ti-chi-bot bot merged commit eb94c8a into pingcap:master Nov 27, 2024
26 checks passed
@CharlesCheung96 CharlesCheung96 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Nov 27, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11807.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11808.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11809.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Nov 27, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11810.

CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 3, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Dec 3, 2024
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 12, 2024
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 12, 2024
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 12, 2024
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Dec 12, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Dec 12, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 13, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jan 3, 2025
ti-chi-bot bot pushed a commit that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unstable bank test
4 participants