-
Notifications
You must be signed in to change notification settings - Fork 293
*: upgrade tidb to include fix #11776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -278,11 +278,11 @@ var testCases = []testCase{ | |||
[]string{"ALTER TABLE `xtest`.`xt1` DROP INDEX IF EXISTS `i1`"}, | |||
}, | |||
{ | |||
"alter table `t1` drop foreign key if exists fk_t2_id", | |||
[]string{"ALTER TABLE `test`.`t1` DROP FOREIGN KEY IF EXISTS `fk_t2_id`"}, | |||
"alter table `t1` drop foreign key fk_t2_id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11776 +/- ##
================================================
+ Coverage 55.1612% 55.1714% +0.0101%
================================================
Files 1002 1002
Lines 137399 137399
================================================
+ Hits 75791 75805 +14
+ Misses 56066 56055 -11
+ Partials 5542 5539 -3 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <[email protected]>
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #11768
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note