Skip to content

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #11768

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2024
@@ -278,11 +278,11 @@ var testCases = []testCase{
[]string{"ALTER TABLE `xtest`.`xt1` DROP INDEX IF EXISTS `i1`"},
},
{
"alter table `t1` drop foreign key if exists fk_t2_id",
[]string{"ALTER TABLE `test`.`t1` DROP FOREIGN KEY IF EXISTS `fk_t2_id`"},
"alter table `t1` drop foreign key fk_t2_id",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ti-chi-bot ti-chi-bot bot added the area/dm Issues or PRs related to DM. label Nov 20, 2024
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.1714%. Comparing base (8e3b63a) to head (262bcd6).
Report is 12 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.6169% <ø> (+0.0398%) ⬆️
dm 50.0423% <ø> (-0.0212%) ⬇️
engine 53.2223% <ø> (-0.0113%) ⬇️
Flag Coverage Δ
unit 55.1714% <ø> (+0.0101%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11776        +/-   ##
================================================
+ Coverage   55.1612%   55.1714%   +0.0101%     
================================================
  Files          1002       1002                
  Lines        137399     137399                
================================================
+ Hits          75791      75805        +14     
+ Misses        56066      56055        -11     
+ Partials       5542       5539         -3     

@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-20 03:10:29.628741576 +0000 UTC m=+1217.248396087: ☑️ agreed by Benjamin2037.
  • 2024-11-20 03:26:07.969175213 +0000 UTC m=+2155.588829729: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit f1f286a into pingcap:master Nov 20, 2024
28 checks passed
@D3Hunter D3Hunter deleted the upgrade-tidb branch November 20, 2024 04:10
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #11777.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 20, 2024
mjonss pushed a commit to mjonss/tiflow that referenced this pull request Nov 25, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 3, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11821.

ti-chi-bot bot pushed a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dm Issues or PRs related to DM. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dm: after physical import, the auto id might have a large jump
4 participants