ddl(ticdc): process only JobStateDone DDL jobs and remove the need to capture the tidb_ddl_history
#11836
+24
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tory instead of tidb_ddl_job table (pingcap#10907)" This reverts commit 8d6a9e1.
ti-chi-bot
bot
added
release-note-none
wlwilliamx
changed the title
JobStateDone DDL jobs and remove the need to monitor the tidb_ddl_historyJobStateDone DDL jobs and remove the need to capture the tidb_ddl_history
|
/test cdc-integration-storage-test |
|
/test cdc-integration-mysql-test |
|
/test dm-integration-test |
|
/retest |
wlwilliamx
force-pushed
the
fix/only-handle-done-state-ddl
branch
from
295de41 to
55bca14
Compare
|
/retest |
|
/test cdc-integration-kafka-test |
|
/test dm-integration-test |
1 similar comment
|
/test dm-integration-test |
|
/test cdc-integration-kafka-test |
|
/retest |
CharlesCheung96
approved these changes
Dec 20, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
hongyunyan
approved these changes
Dec 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CharlesCheung96, hongyunyan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
CharlesCheung96
added
the
needs-cherry-pick-release-8.5
|
/test verify |
|
/retest |
1 similar comment
|
/retest |
|
In response to a cherrypick label: new pull request created to branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #11816
What is changed and how it works?
PR Description
This PR updates TiCDC to align its DDL handling logic with TiDB v8.3.0’s changes to the
enable_fast_create_tablefeature, improving efficiency and simplifying the architecture.Background
In TiDB versions prior to v8.3.0:
enable_fast_create_table=on,batch create tablesDDL jobs transitioned directly to theJobStateSyncedstate, bypassing the JobStateDone state.Batch create tablesDDL jobs were written only to thetidb_ddl_historytable in theJobStateSyncedstate.As of TiDB v8.3.0:
Batch create tablesDDL jobs now follow the same lifecycle as other DDL jobs, including theJobStateDonestate.tidb_ddl_jobtable, making thetidb_ddl_historytable unnecessary for TiCDC.For more details, see issue #11816.
Changes in This PR
1. Process Only
JobStateDoneDDL JobsJobStateDoneDDL jobs forcreate tableoperations.JobStateSyncedstate, simplifying the DDL processing logic.2. Stop Monitoring
tidb_ddl_historytidb_ddl_historytable for DDL changes.enable_fast_create_tablearchitecture.3. Resolve Redundant DDL Processing
create tableDDL job was processed twice in bothJobStateDoneandJobStateSyncedstates.4. Reduce Latency
JobStateDoneDDL jobs directly, this change avoids delays introduced by waiting for theJobStateSyncedstate transition.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note