Skip to content

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11869

What problem does this PR solve?

Issue Number: close #11868

What is changed and how it works?

This PR removes the SchemaVersion field and its associated logic from the schemaStorage component in TiCDC. The change is part of an effort to remove schema change checking and reduce redundant logic.

Related to #11733.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify 51da60e link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@3703b18). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 59.5796% <0.0000%> (?)
dm 50.1174% <0.0000%> (?)
engine 53.2618% <0.0000%> (?)
Flag Coverage Δ
unit 55.1680% <66.6666%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.5     #11920   +/-   ##
================================================
  Coverage               ?   55.1680%           
================================================
  Files                  ?       1003           
  Lines                  ?     136793           
  Branches               ?          0           
================================================
  Hits                   ?      75466           
  Misses                 ?      55801           
  Partials               ?       5526           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jan 10, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 17, 2025
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Mar 4, 2025
@wlwilliamx
Copy link
Contributor

/retest

@wlwilliamx
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Apr 14, 2025
Copy link
Contributor

ti-chi-bot bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlwilliamx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Apr 14, 2025
@ti-chi-bot ti-chi-bot bot merged commit 4c3451c into pingcap:release-8.5 Apr 14, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants