Skip to content

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented May 20, 2025

What problem does this PR solve?

Issue Number: ref #11566

What is changed and how it works?

  1. Fix the incorrect unit test about drop table.
  2. Add a rename table case in the integration test.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Copy link
Contributor

ti-chi-bot bot commented May 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @wk989898, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini or gemini-code-assist here, providing a summary of this pull request. Based on the title [DNM]: test rename table in debezium and the minimal changes, this PR appears to be a work-in-progress or a specific test case setup. The primary intent seems to be adding or verifying the handling of the RENAME TABLE DDL statement within the Debezium integration tests. The change itself is a single line added to a SQL script used by these tests.

Highlights

  • Debezium Integration Test: This PR modifies a SQL script used in the Debezium integration tests.
  • RENAME TABLE DDL Test: A specific RENAME TABLE statement is added to the test script, likely to test how Debezium handles renaming a table back to its original name or a different schema/name combination.

Changelog

  • tests/integration_tests/debezium/sql/ddl.sql
    • Added a RENAME TABLE statement (RENAME TABLE rename_t8 TO test.t8;) at line 148 to the DDL test script.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


Test DDL runs,
Rename table, check the stream,
Debezium flows.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@wk989898
Copy link
Collaborator Author

/test pull-cdc-integration-kafka-test

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, currently marked as "Do Not Merge" (DNM), adds a test case to tests/integration_tests/debezium/sql/ddl.sql. The change introduces a RENAME TABLE statement that renames a table to a fully qualified name (e.g., database.table).

This is a good addition as it enhances test coverage for DDL handling, specifically for RENAME TABLE operations where the target table name includes the schema/database qualifier. The change is clear, concise, and fits well within the existing test structure.

If this PR were to be prepared for merging (i.e., the DNM prefix removed), please ensure the pull request description, checklist, and release note sections are thoroughly completed as per the template.

Merge Readiness

As this pull request is marked "[DNM]" (Do Not Merge), it is understood to be a work in progress or for testing purposes and is not currently intended for merging.

Should this PR be considered for merging in the future, the following would be required:

  • Removal of the "[DNM]" prefix from the title.
  • A complete and accurate pull request description, including the problem solved and the changes made.
  • Filling out the checklist, including test details.
  • Providing an appropriate release note if applicable, or stating None.

The code change itself is minor and appears correct for its testing purpose. I am unable to approve pull requests; please ensure further review and approval by authorized maintainers before any merge.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 20, 2025
@wk989898 wk989898 changed the title [DNM]: test rename table in debezium codec(ticdc): fix test in debezium protocol May 20, 2025
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 20, 2025
@wk989898 wk989898 marked this pull request as ready for review May 20, 2025 08:14
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.0546%. Comparing base (40b34d5) to head (8fd0f7d).
Report is 1 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 59.2611% <ø> (-0.0015%) ⬇️
dm 50.0872% <ø> (+0.0076%) ⬆️
engine 53.2167% <ø> (-0.0170%) ⬇️
Flag Coverage Δ
unit 55.0546% <ø> (+0.0020%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #12176        +/-   ##
================================================
+ Coverage   55.0525%   55.0546%   +0.0020%     
================================================
  Files          1030       1030                
  Lines        143225     143225                
================================================
+ Hits          78849      78852         +3     
+ Misses        58577      58575         -2     
+ Partials       5799       5798         -1     
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels May 20, 2025
@wk989898
Copy link
Collaborator Author

/test pull-cdc-integration-kafka-test

@ti-chi-bot ti-chi-bot bot added the lgtm label May 20, 2025
Copy link
Contributor

ti-chi-bot bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, wlwilliamx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,wlwilliamx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 20, 2025
Copy link
Contributor

ti-chi-bot bot commented May 20, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-05-20 09:29:55.06370592 +0000 UTC m=+81232.164873128: ☑️ agreed by 3AceShowHand.
  • 2025-05-20 10:41:19.324589039 +0000 UTC m=+85516.425756262: ☑️ agreed by wlwilliamx.

@ti-chi-bot ti-chi-bot bot merged commit 8a7da93 into pingcap:master May 20, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants