codec: fix a panic in Debezium when configuring column-selector (#12210) #12212
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot
added
do-not-merge/hold
|
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@wk989898 This PR has conflicts, I have hold it. |
ti-chi-bot
bot
added
size/XXL
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a panic in the Debezium codec related to column selection and fixes integration tests to ensure proper replication in scenarios involving multiple SQL statements. The changes prevent the codec from crashing when encountering nil columns and improve the reliability of integration tests.
Highlights
- Debezium Codec Fix: Addresses a panic in the Debezium codec that occurs when configuring column-selector, specifically when some columns are not selected and are therefore
nilduring encoding. The fix involves skippingnilcolumns during the encoding process. - Integration Test Fixes: Corrects an issue in integration tests where the second SQL statement might not replicate to the downstream when running two SQL statements and checking for table existence.
- Debezium Field Schema: Modifies the
writeDebeziumFieldSchemafunction to handlenilcolumns and virtual columns correctly, ensuring that the schema is generated accurately even when some columns are not selected or are virtual.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a panic in the Debezium codec when a column-selector is configured by adding nil checks for columns. The PR also fixes other integration tests. The most important issue is the presence of unresolved merge conflicts in pkg/sink/codec/debezium/codec.go, which must be resolved.
pkg/sink/codec/debezium/codec.go
Outdated
| <<<<<<< HEAD | ||
| err = c.writeDebeziumFieldValue(writer, col, colInfos[i].Ft) | ||
| ======= | ||
| if col == nil { | ||
| continue | ||
| } | ||
| colx := model.GetColumnDataX(col, tableInfo) | ||
| err = c.writeDebeziumFieldValue(writer, colx, colInfos[i].Ft) | ||
| >>>>>>> 9bc740d55a (codec: fix a panic in Debezium when configuring column-selector (#12210)) |
There was a problem hiding this comment.
This code block contains unresolved merge conflict markers (<<<<<<< HEAD, =======, >>>>>>>), which will cause a compilation failure and must be resolved. The colx variable is not needed, as col already contains all the necessary information.
if col == nil {
continue
}
err = c.writeDebeziumFieldValue(writer, col, colInfos[i].Ft)
pkg/sink/codec/debezium/codec.go
Outdated
| <<<<<<< HEAD | ||
| colInfos := e.TableInfo.GetColInfosForRowChangedEvent() | ||
| for i, col := range validCols { | ||
| c.writeDebeziumFieldSchema(fieldsWriter, col, colInfos[i].Ft) | ||
| ======= | ||
| for _, col := range validCols { | ||
| if col == nil { | ||
| continue | ||
| } | ||
| colx := model.GetColumnDataX(col, e.TableInfo) | ||
| ft := &e.TableInfo.GetColumnByID(colx.ColumnID).FieldType | ||
| c.writeDebeziumFieldSchema(fieldsWriter, colx, ft) | ||
| } | ||
| if e.TableInfo.HasVirtualColumns() { | ||
| for _, colInfo := range e.TableInfo.Columns { | ||
| if model.IsColCDCVisible(colInfo) { | ||
| continue | ||
| } | ||
| data := &model.ColumnData{ColumnID: colInfo.ID} | ||
| colx := model.GetColumnDataX(data, e.TableInfo) | ||
| ft := &e.TableInfo.GetColumnByID(colx.ColumnID).FieldType | ||
| c.writeDebeziumFieldSchema(fieldsWriter, colx, ft) | ||
| } | ||
| >>>>>>> 9bc740d55a (codec: fix a panic in Debezium when configuring column-selector (#12210)) | ||
| } |
There was a problem hiding this comment.
This block also contains unresolved merge conflict markers that will prevent compilation. Please resolve them.
for _, col := range validCols {
if col == nil {
continue
}
colx := model.GetColumnDataX(col, e.TableInfo)
ft := &e.TableInfo.GetColumnByID(colx.ColumnID).FieldType
c.writeDebeziumFieldSchema(fieldsWriter, colx, ft)
}
if e.TableInfo.HasVirtualColumns() {
for _, colInfo := range e.TableInfo.Columns {
if model.IsColCDCVisible(colInfo) {
continue
}
data := &model.ColumnData{ColumnID: colInfo.ID}
colx := model.GetColumnDataX(data, e.TableInfo)
ft := &e.TableInfo.GetColumnByID(colx.ColumnID).FieldType
c.writeDebeziumFieldSchema(fieldsWriter, colx, ft)
}
}
ti-chi-bot
bot
added
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (0.0000%) is below the target coverage (60.0000%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.1 #12212 +/- ##
================================================
Coverage ? 57.2578%
================================================
Files ? 854
Lines ? 126580
Branches ? 0
================================================
Hits ? 72477
Misses ? 48654
Partials ? 5449 🚀 New features to boost your workflow:
|
|
/retest-required |
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #12210
What problem does this PR solve?
Issue Number: close #12208
What is changed and how it works?
When configuring the column-selector, some columns that are not selected must be ignored. Because these columns are
niland cause a panic when encoding.This pr also fixes other integration tests. When running two SQL and checking that the same table exists, the second SQL may not replicate to the downstream.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note