-
Notifications
You must be signed in to change notification settings - Fork 31
Setup logging after reading the config file #856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @djshow832 |
This should probably get some more tests:
|
And with the current
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #856 +/- ##
=======================================
Coverage ? 67.09%
=======================================
Files ? 129
Lines ? 12261
Branches ? 0
=======================================
Hits ? 8226
Misses ? 3451
Partials ? 584
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -68,7 +67,6 @@ func (e *ConfigManager) SetTOMLConfig(data []byte) (err error) { | |||
if originalData == nil || !bytes.Equal(originalData, newData) { | |||
e.sts.checksum = crc32.ChecksumIEEE(newData) | |||
e.sts.data = newData | |||
e.logger.Info("current config", zap.Any("cfg", e.sts.current)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's crucial to print the config every time it changes. You can print it when the loggerManager watches a config change instead.
What problem does this PR solve?
Issue Number: close #855
Problem Summary:
Logging is setup based with the generic
NewConfig()
and used during the initial parsing of the config file. Then later the watcher is correcting things where needed. However the encoder isn't changed. This results in the encoder from the config to be ignored.What is changed and how it works:
As indicated for the changes in
TestChecksum
:Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.