Skip to content

Set default value of spark.tispark.telemetry.enable as false (#2621) #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2023
+4 −4
Merged

Set default value of spark.tispark.telemetry.enable as false (#2621) #2624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/sql/TiExtensions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,14 @@ object TiExtensions {

/**
* check that telemetry is on
* default on
* default off
*
* @param sparkSession
* @return
*/
def telemetryEnable(sparkSession: SparkSession): Boolean = {
sparkSession.sparkContext.conf
.get(TELEMETRY_ENABEL, "true")
.get(TELEMETRY_ENABEL, "false")
.toBoolean
}
}
4 changes: 2 additions & 2 deletions docs/telemetry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Telemetry
By default, TiSpark collect usage information and share the information with PingCAP. You can close it by configuring
`spark.tispark.telemetry.enable = false` in `spark-default.conf`.
By default, TiSpark does not collect usage information and share the information with PingCAP. You can enable it by configuring
`spark.tispark.telemetry.enable = true` in `spark-default.conf`.

When the telemetry collection feature is enabled, usage information will be shared, including(but not limited to):
* A randomly generated telemetry ID.
Expand Down