Support probe tiflash status (#2619) #2635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <[email protected]>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
|
/run-all-tests |
xuanyu66
previously approved these changes
Feb 28, 2023
zhangyangyu
previously approved these changes
Feb 28, 2023
Daemonxiao
previously approved these changes
Mar 1, 2023
|
/run-all-tests |
shiyuhang0
dismissed stale reviews from Daemonxiao, zhangyangyu, and xuanyu66
via
8016a0e
|
/run-all-tests |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 8016a0e
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #2619
What problem does this PR solve?
Support probe TiFlash status.
When you have two TiFlash and suspend one during the job, the suspended TiFlash can still be chosen and the request to it will wait for a timeout for grpc. It wastes resources and affected the whole job's speed.
What is changed and how it works?
When we choose the TiFlash. we call the isalive to probe the status of TiFlash. If it is not ready, drop the task.
Alternatives
In this pr, a background thread poll will refresh the cache of TiFlash store status every time a region task has been generated. Then drop the task whose store is unavailable.
The cons are if there are many tasks, the thread poll will be distributed too much probe tasks.
Another way is to use a corn job to refresh the cache: