Skip to content

Conversation

shiyuhang0
Copy link
Member

@shiyuhang0 shiyuhang0 commented Mar 6, 2023

What problem does this PR solve?

close #2638

What is changed and how it works?

  1. Fix the output of explain: TiSpark no more throw NoSuchElementException when there is no partition after partition prune.

  2. Fix the part of the bug that no partitions will be selected in the range column partition table.

TiSpark will contain '' when generates partition exprs. For example, if your DDL is PARTITION p1 VALUES LESS THAN ('CN001'), you will get something like ${column_name} less than "'CN001'". Then, your filter can not match the partition exprs.

After Fix, TiSpark will convert

  • 'CN001' -> "CN001"
  • '''CN001''' -> "'CN001'"

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 6, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Daemonxiao
  • xuanyu66

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0 shiyuhang0 added needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.0 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 needs-cherry-pick-release-3.2 labels Mar 7, 2023
@shiyuhang0 shiyuhang0 force-pushed the range_col branch 2 times, most recently from a5ded91 to 7b2a99e Compare March 13, 2023 05:19
@shiyuhang0
Copy link
Member Author

/run-all-tests

@xuanyu66
Copy link
Collaborator

/run-all-tests

@shiyuhang0
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 10e42b2

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.2: #2654.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Mar 19, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-2.4: #2655.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Mar 19, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-2.5: #2656.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Mar 19, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.0: #2657.

ti-chi-bot pushed a commit to ti-chi-bot/tispark that referenced this pull request Mar 19, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.1: #2658.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-2.4 PR which needs to be cherry-picked to release-2.4 needs-cherry-pick-release-2.5 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.0 PR which needs to be cherry-picked to release-2.5 needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 needs-cherry-pick-release-3.2 status/can-merge status/LGT2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Read from range column partition table error
4 participants