Skip to content

Conversation

shiyuhang0
Copy link
Member

@shiyuhang0 shiyuhang0 commented Mar 15, 2023

What problem does this PR solve?

close #2649

What is changed and how it works?

The behavior of other version/client

  1. TiSpark 3.0 does not pass unique in indexscan executor
  2. TIDB needs some checks before passing unique https://github.com/pingcap/tidb/blob/4ae5be190b0017675deedd9af8b80d8868e03f0e/planner/core/plan_to_pb.go#L271

TiSpark lacks the necessary information to judge if it can pass unique. So we just delete it.
Lack unique in indexscan only slows the performance but does not influence the correct. See the pr's comment for more details pingcap/tidb#29650

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 15, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Daemonxiao
  • xuanyu66

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0 shiyuhang0 added needs-cherry-pick-release-3.1 PR which needs to be cherry-picked to release-3.1 needs-cherry-pick-release-3.2 labels Mar 15, 2023
@shiyuhang0
Copy link
Member Author

/run-all-tests

1 similar comment
@shiyuhang0
Copy link
Member Author

/run-all-tests

@shiyuhang0
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 59ebad9

@ti-chi-bot ti-chi-bot merged commit c673d55 into pingcap:master Mar 23, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.1: #2665.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-3.2: #2666.

ti-chi-bot added a commit that referenced this pull request Mar 28, 2023
ti-chi-bot added a commit that referenced this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Return empty data
4 participants