Skip to content

ktlint 0.47 displays plenty of warnings about the --disabled_rules argument usage #1599

@0x6675636b796f75676974687562

Description

Expected Behavior

The --disabled_rules is a documented flag, so using it should result in no extra warnings:

$ ./ktlint -V
0.47.0
$ ./ktlint --help | grep -A3 disabled
      --disabled_rules=<disabledRules>
                        Comma-separated list of rules to globally disable. To
                          disable standard ktlint rule-set use
                          --disabled_rules=standard

Observed Behavior

Yet, running ktlint 0.47 (with --disabled_rules specified) against any codebase now produces plenty of warnings:

14:36:39.886 [pool-1-thread-1] WARN com.pinterest.ktlint.core.api.UsesEditorConfigProperties - Property 'disabled_rules' is deprecated: Rename property 'disabled_rules' to 'ktlint_disabled_rules' in all '.editorconfig' files.
14:36:39.886 [pool-1-thread-1] WARN com.pinterest.ktlint.core.api.UsesEditorConfigProperties - Property 'disabled_rules' is deprecated: Rename property 'disabled_rules' to 'ktlint_disabled_rules' in all '.editorconfig' files.
14:36:39.886 [pool-1-thread-1] WARN com.pinterest.ktlint.core.api.UsesEditorConfigProperties - Property 'disabled_rules' is deprecated: Rename property 'disabled_rules' to 'ktlint_disabled_rules' in all '.editorconfig' files.
14:36:39.886 [pool-1-thread-1] WARN com.pinterest.ktlint.core.api.UsesEditorConfigProperties - Property 'disabled_rules' is deprecated: Rename property 'disabled_rules' to 'ktlint_disabled_rules' in all '.editorconfig' files.
14:36:39.886 [pool-1-thread-1] WARN com.pinterest.ktlint.core.api.UsesEditorConfigProperties - Property 'disabled_rules' is deprecated: Rename property 'disabled_rules' to 'ktlint_disabled_rules' in all '.editorconfig' files.
14:36:39.886 [pool-1-thread-1] WARN com.pinterest.ktlint.core.api.UsesEditorConfigProperties - Property 'disabled_rules' is deprecated: Rename property 'disabled_rules' to 'ktlint_disabled_rules' in all '.editorconfig' files.
14:36:39.886 [pool-1-thread-1] WARN com.pinterest.ktlint.core.api.UsesEditorConfigProperties - Property 'disabled_rules' is deprecated: Rename property 'disabled_rules' to 'ktlint_disabled_rules' in all '.editorconfig' files.

Steps to Reproduce

  1. Download the fat JAR from https://github.com/pinterest/ktlint/releases/tag/0.47.0.
  2. Download an external ruleset JAR from https://github.com/saveourtool/diktat/releases/latest.
  3. Run the far JAR against any non-empty codebase as
    java -Xmx512m --add-opens java.base/java.lang=ALL-UNNAMED -jar ktlint -R diktat-1.2.3.jar --disabled_rules=standard
  4. A sheetful of warnings will appear. This is a regression against version 0.46.1.

Your Environment

  • Version of ktlint used: 0.47
  • Relevant parts of the .editorconfig settings: none
  • Name and version (or code for custom task) of integration used (Gradle plugin, Maven plugin, command line, custom Gradle task): CLI.
  • Version of Gradle used (if applicable): N/A
  • Operating System and version:
    • MINGW64_NT-10.0-19043 unit-725 3.3.4-341.x86_64 2022-05-09 11:56 UTC x86_64 Msys
    • Linux unit-725 5.10.102.1-microsoft-standard-WSL2 #1 SMP Wed Mar 2 00:30:59 UTC 2022 x86_64 GNU/Linux

Metadata

Metadata

Assignees

No one assigned

    Labels

    cliktlint command line interface

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions