CfEnv: allow passing in values of VCAP_SERVICES & VCAP_APPLICATION #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it easier to test components using CfEnv to parse a given VCAP_SERVICES string.
As can be seen in CfEnv's tests, it is possible to mock
System.getenv
with JMockit, but patching globally scoped objects is quite invasive and also requires configuring a Java agent.This change adds a second constructor to CfEnv, so that the VCAP_SERVICES value can simply be passed in.
A Spring Configuration class like the following...
...can then be easily tested using
MockEnvironment
.