Restores support for user:pass@host/db style SQLServer URI #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotal-david-osullivan
force-pushed
the
sqlserver-ups-uri
branch
from
43cabaa to
b0b5689
Compare
dmikusa
approved these changes
Aug 4, 2022
java-cfenv-jdbc/src/main/java/io/pivotal/cfenv/jdbc/SqlServerJdbcUrlCreator.java
Outdated
Show resolved
Hide resolved
pivotal-david-osullivan
force-pushed
the
sqlserver-ups-uri
branch
from
b0b5689 to
7e59c87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQLServer URI format of
sqlserver://username:passwordg@host:1433/databasewas originally supported and then removed. This change brought support for the formatsqlserver://host:1433;database=foo.This PR restores support for the original format which is a valid URL. It still supports the alternative format with semi-colons but because that is not a valid URL, we recommend using the original format when possible.