Skip to content

Conversation

KSXGitHub
Copy link
Contributor

Resolves #8941

@KSXGitHub KSXGitHub marked this pull request as ready for review April 1, 2025 12:22
@KSXGitHub KSXGitHub requested a review from zkochan as a code owner April 1, 2025 12:22
@KSXGitHub KSXGitHub requested a review from zkochan April 2, 2025 08:28
zkochan

This comment was marked as resolved.

@zkochan

This comment was marked as resolved.

@KSXGitHub

This comment was marked as resolved.

@KSXGitHub KSXGitHub requested a review from zkochan April 4, 2025 06:30
zkochan

This comment was marked as resolved.

@zkochan

This comment was marked as resolved.

@zkochan zkochan requested a review from a team April 4, 2025 12:39
@KSXGitHub
Copy link
Contributor Author

Ah, so that's what they mean! Well, if it was up to me, I would have named them addParam, rawAddParam, parsedAddParam, dependencyValue, rawDependencyValue, parsedDependencyValue.

Anyway, I will fix the names that were introduced by this PR to use pref, spec, and wantedDependency correctly.

@zkochan

This comment was marked as resolved.

@zkochan zkochan changed the title feat: jsr feat: add support for the jsr: protocol Apr 20, 2025
@zkochan zkochan merged commit 9c3dd03 into main Apr 20, 2025
15 checks passed
@zkochan zkochan deleted the jsr-8941 branch April 20, 2025 09:51
@zkochan
Copy link
Member

zkochan commented Apr 21, 2025

🚢 10.9

@btea
Copy link
Member

btea commented Apr 21, 2025

I'm not sure if this is a problem with the parsing result. When I execute pnpm add jsr:@sxzz/tsdown, the corresponding dependencies can be installed, but the content in package.json is missing. https://jsr.io/@sxzz/tsdown/0.9.1/package.json

image

cc @KSXGitHub @zkochan

@KSXGitHub
Copy link
Contributor Author

@btea The JSR npm compatibility layer seems to generate its own package.json

package.json
{
  "name": "@jsr/sxzz__tsdown",
  "version": "0.9.1",
  "homepage": "https://jsr.io/@sxzz/tsdown",
  "type": "module",
  "dependencies": {
    "ansis": "^3.17.0",
    "chokidar": "^4.0.3",
    "consola": "^3.4.2",
    "debug": "^4.4.0",
    "find-up-simple": "^1.0.1",
    "pkg-types": "^2.1.0",
    "publint": "^0.3.12",
    "rolldown": "^1.0.0-beta.7",
    "rolldown-plugin-dts": "^0.8.0",
    "tinyexec": "^1.0.1",
    "tinyglobby": "^0.2.12",
    "unconfig": "^7.3.1",
    "unplugin-unused": "^0.4.4",
    "vite": "^6.3.2"
  },
  "exports": {
    ".": {
      "types": "./_dist/src/index.d.ts",
      "default": "./src/index.js"
    }
  },
  "_jsr_revision": 11
}

The links to the tarballs is in https://npm.jsr.io/@jsr/sxzz__tsdown

@KSXGitHub
Copy link
Contributor Author

@btea npm jsr add @sxzz/tsdown also gives the same package.json:

screenshot

@btea
Copy link
Member

btea commented Apr 21, 2025

Looks a bit weird, I haven't used jsr before, so is this normal?

@KSXGitHub
Copy link
Contributor Author

Looks a bit weird, I haven't used jsr before, so is this normal?

We can't do anything about it because we don't control the jsr registry.

@btea
Copy link
Member

btea commented Apr 21, 2025

Got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for installing JSR packages directly
5 participants