Skip to content

fix: add bottom margin for ask again later link #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: add bottom margin for ask again later link #1335

wants to merge 2 commits into from

Conversation

ltfschoen
Copy link

Fixes #1334

@Tbaut
Copy link
Contributor

Tbaut commented Mar 24, 2024

Margins are a mess between browsers. The pop-up window when clinking on the extension icon, or appearing as stand alone have different behaviors depending on the browser. See #1242 and related issues.

@ltfschoen
Copy link
Author

ltfschoen commented Mar 24, 2024 •
edited
Loading

  • before
Screenshot 2024-03-24 at 9 41 41 am
  • after
Screenshot 2024-03-24 at 10 04 15 am

note: this was using Firefox 123.0

@Tbaut
Copy link
Contributor

Tbaut commented Mar 24, 2024

Please test it out in many platforms, and browsers, and in the pop-up (when clicking on the ici) as well as the standalone window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@Dioliode Dioliode Dioliode approved these changes

@b0key b0key b0key approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing bottom padding for "Ask again later" link
4 participants
@ltfschoen @Tbaut @Dioliode @b0key