fix: use href attribute in deauthorization link to correctly handle D… #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gildo
force-pushed
the
gildo/fix-delete-link-method
branch
from
09815d9 to
0b03683
Compare
|
Do you think |
Hi @arthurbailao, I have made no tests on older versions of Phoenix, and I'm pretty new to the framework, but I guess that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR addresses an issue with de-authorization links. The generated link did not correctly handle the method="delete" attribute, which caused a GET request instead of DELETE.
Ref: Can't get delete links to work in Phoenix 1.7rc.
Thanks for your work.
Best,
Gildo