-
Notifications
You must be signed in to change notification settings - Fork 632
Deprecate AvatarPair component - move to @primer/react/deprecated while maintaining backward compatibility #6468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
493d2d3
44fc56f
0857415
5b513f6
dc6ee83
3b760cb
5ea369f
f527ee9
ea6c23d
ab977f5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
[] | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -184,25 +184,7 @@ const components = new Map([ | |
], | ||
}, | ||
], | ||
[ | ||
'AvatarPair', | ||
{ | ||
stories: [ | ||
{ | ||
id: 'components-avatarpair--default', | ||
name: 'Default', | ||
}, | ||
{ | ||
id: 'components-avatarpair-features--parent-circle', | ||
name: 'Parent Circle', | ||
}, | ||
{ | ||
id: 'components-avatarpair-features--parent-square', | ||
name: 'Parent Square', | ||
}, | ||
], | ||
}, | ||
], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we do this now or when we remove the component? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I removed the AvatarPair entry from the e2e test generation script as part of deprecation since we're removing all internal usage. This helps maintain consistency - the component is deprecated and should not have new e2e tests generated. Commit: 3b760cb |
||
|
||
[ | ||
'BranchName', | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleted the results.json file as requested. Commit: 3b760cb