fix(styled-react): update types output #6649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9085989 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes TypeScript type generation for the @primer/styled-react package and adds npm package linting to prevent similar issues in the future. The main issue was that types were not being emitted to the correct location in the dist folder due to test files being included in the TypeScript compilation.
- Update TypeScript build configuration to exclude test files and config directories from type generation
- Add
publinttool for npm package validation with a newlint:npmtask - Integrate npm package linting into the CI pipeline
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
turbo.json |
Adds new lint:npm task configuration to the build pipeline |
packages/styled-react/tsconfig.build.json |
Excludes test files and config directories from TypeScript compilation |
packages/styled-react/package.json |
Adds lint:npm script and publint dependency |
.github/workflows/ci.yml |
Integrates npm package linting into CI workflow |
.changeset/salty-geese-own.md |
Documents the patch release for the styled-react package |
Co-authored-by: Copilot <[email protected]>
jonrohan
approved these changes
Aug 22, 2025
size-limit report 📦
|
Merged
pksjce
pushed a commit
that referenced
this pull request
Aug 25, 2025
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6643
Update the
tsconfig.build.jsonexclude list so that our types are generated in the correct location for@primer/styled-react. This also adds a new task,lint:npm, to hopefully avoid these types of issues with publishing in the future 😅Changelog
New
lint:npmtask to turbo and topackages/styled-reacttsconfig.build.jsonso types are emitted to correct paths indistfolderChanged
Removed
Rollout strategy