Remove support for sx from LabelGroup component
#6682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llastflowers
added
the
integration-tests: skipped manually
🦋 Changeset detectedLatest commit: da0bd77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the sx prop support from the LabelGroup component as part of the migration away from @primer/styled-react. Since there is no current usage of sx on LabelGroup components in dotcom, this breaking change can be safely implemented.
Key changes:
- Removes
sxprop fromLabelGroupcomponent interface and implementation - Replaces
Boxcomponents with nativedivelements and inline styles in overlay - Updates styled component to remove
sxstyling function
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/react/src/LabelGroup/LabelGroup.tsx | Removes sx prop support, eliminates Box imports, converts overlay layout to native divs with inline styles |
| .changeset/seven-coats-hang.md | Documents breaking change for major version release |
TylerJDev
approved these changes
Sep 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/5795
Current
sxusage: 0✅ Don't need to separately update github-ui components to use @primer/styled-react
Changelog
Removed
Remove support for
sxfrom theLabelGroupcomponent, and associated stories, docs, and testsRollout strategy
This component currently has 0
sxusage in dotcom, and therefore does not need the @primer/styled-react wrapper. this will be confirmed again before merging.Merge checklist