(feat) Remove Json marshaling #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When instantiating referenced resource, Sveltos fecthes the content of referenced ConfigMap/Secret instances. The result is a map[string]string The only section that is a template, is the value (keys can be assumed to be constant). This PR replaces the json.Marshal of the string with code that walks of keys in the map, and instantiated the values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When instantiating referenced resource, Sveltos fecthes the content of referenced ConfigMap/Secret instances. The result is a map[string]string
The only section that is a template, is the value (keys can be assumed to be constant). This PR replaces the json.Marshal of the string with code that walks of keys in the map, and instantiated the values.
Fixes #349