Add missing _total suffix to error counters
#191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixup for #184: these are counters, so we should name them accordingly. Signed-off-by: Matthias Rampke <[email protected]>
|
:doh: sorry about that! of course its a counter... |
tnosaj
approved these changes
Dec 6, 2023
SuperQ
approved these changes
Dec 6, 2023
matthiasr
added a commit
that referenced
this pull request
Dec 6, 2023
Fixup for 0.14.0 #191, Go update #190 Signed-off-by: Matthias Rampke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup for #184: these are counters, so we should name them accordingly.
FYI @tnosaj