Skip to content

Conversation

kostasdizas
Copy link
Contributor

@kostasdizas kostasdizas commented Jul 17, 2023

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Implemented a Protobuf Raw deserialiser that works like protoc --decode_raw. This is a no config alternative to the existing ProtobufFileSerde

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
Cute bumblebee

@kostasdizas kostasdizas requested a review from a team as a code owner July 17, 2023 22:00
@Haarolean Haarolean requested a review from iliax July 18, 2023 06:23
@Haarolean Haarolean added type/enhancement En enhancement to an already existing feature scope/backend labels Jul 18, 2023
@iliax
Copy link
Contributor

iliax commented Jul 25, 2023

@kostasdizas, thank you for your contribution! I left couple comments and suggestions - please take a look.

@Haarolean Haarolean added the status/pending Further information is requested label Aug 1, 2023
@iliax iliax added status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. and removed status/feature_testing This branch/PR has been deployed to a separate PRIVATE environment for testing. labels Aug 5, 2023
Make schemas more consistent
@iliax iliax enabled auto-merge (squash) August 10, 2023 14:53
@iliax iliax removed the status/pending Further information is requested label Aug 10, 2023
@iliax iliax merged commit d915de4 into provectus:master Aug 11, 2023
@Haarolean Haarolean added this to the 0.8 milestone Aug 11, 2023
@kostasdizas kostasdizas deleted the feature/protobuf-raw-serde branch August 11, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/enhancement En enhancement to an already existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants