Skip to content

BE: RBAC: Skip rbac checks in case of app config #4078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2023
Merged

BE: RBAC: Skip rbac checks in case of app config #4078

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1b68fd
Skip rbac checks in case of app config
Haarolean Aug 1, 2023
4da67e8
Review fix
Haarolean Aug 1, 2023
a8fc866
change modifier
Haarolean Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/rbac/AccessControlService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@
@Slf4j
public class AccessControlService {

private static final String ACCESS_DENIED = "Access denied";

@Nullable
private final InMemoryReactiveClientRegistrationRepository clientRegistrationRepository;
private final RoleBasedAccessControlProperties properties;
Expand Down Expand Up @@ -97,6 +99,17 @@ public Mono<Void> validateAccess(AccessContext context) {
return Mono.empty();
}

if (CollectionUtils.isNotEmpty(context.getApplicationConfigActions())) {
return getUser()
.doOnNext(user -> {
boolean accessGranted = isApplicationConfigAccessible(context, user);

if (!accessGranted) {
throw new AccessDeniedException(ACCESS_DENIED);
}
}).then();
}

return getUser()
.doOnNext(user -> {
boolean accessGranted =
Expand All @@ -113,7 +126,7 @@ && isAclAccessible(context, user)
&& isAuditAccessible(context, user);

if (!accessGranted) {
throw new AccessDeniedException("Access denied");
throw new AccessDeniedException(ACCESS_DENIED);
}
})
.then();
Expand Down