Skip to content

Warn user if environment variables are used #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Warn user if environment variables are used #5816

wants to merge 1 commit into from

Conversation

Akasurde
Copy link

When session.verify=False, session.trust_env=True and
REQUESTS_CA_BUNDLE or CURL_CA_BUNDLE is defined as environment
variables then, notify user that requests will use environment variables
rather than silently failing.

partially fixes: #3829

Signed-off-by: Abhijeet Kasurde [email protected]

@Akasurde
Copy link
Author

I spend hours debugging this error. I am aware that this odd behavior is fixed in 3.* release.

@Akasurde Akasurde mentioned this pull request May 14, 2021
Open
sigmavirus24
sigmavirus24 reviewed May 14, 2021
View reviewed changes
@hardenchant
Copy link

hardenchant commented May 14, 2021 •
edited
Loading

Really nice pr, I checked it – warnings works well, can save a tons of devs time.
It would be nice to have more verbose warning text, for those who are not familiar with this problem.

@Akasurde
Copy link
Author

It would be nice to have more verbose warning text, for those who are not familiar with this problem.

Could you please suggest something? 😂

@sigmavirus24
Copy link
Contributor

Closing/re-opening since I can't trigger CI to run here

@sigmavirus24 sigmavirus24 reopened this Jul 7, 2021
@nateprewitt nateprewitt changed the base branch from master to main January 3, 2022 15:05
@intgr
Copy link

intgr commented Jun 2, 2022

What's the status of this PR?

@intgr
Copy link

intgr commented Jun 2, 2022

I am aware that this odd behavior is fixed in 3.* release.

From #6050 looks like 3.x isn't going to happen any time soon, and commitments to fix things in 3.x don't necessarily hold.

@Akasurde
Copy link
Author

Akasurde commented Jun 2, 2022

What's the status of this PR?

I would love to see this PR getting merged. Let me know if you need something from myside.

@Akasurde
Warn user if environment variables are used
e95260a 
When session.verify=False, session.trust_env=True and
REQUESTS_CA_BUNDLE or CURL_CA_BUNDLE is defined as environment
variables then, notify user that requests will use environment variables
rather than silently failing.

partially fixes: psf#3829

Signed-off-by: Abhijeet Kasurde <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigmavirus24 sigmavirus24 sigmavirus24 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session.verify=False ignored when REQUESTS_CA_BUNDLE environment variable is set
4 participants
@Akasurde @hardenchant @sigmavirus24 @intgr