Fix utils functions with invalid ip/cidr inputs #6675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kennethreitz, @Lukasa, @sigmavirus24, @nateprewitt, @slingamn, This is my first contribution to this project, and I don't know if is necessary request to someone to review the PR |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
How can i test this case? |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Pjrich1313
reviewed
Oct 31, 2024
| "1.1.1.1 someone was here...", | ||
| "localhost.localdomain", | ||
| ), | ||
| ) | ||
| def test_invalid(self, value): | ||
| assert not is_ipv4_address(value) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pjrich1313
reviewed
Aug 4, 2025
vcapparelli
force-pushed
the
issue-5131
branch
from
c735ae5 to
26b8b17
Compare
|
@Pjrich1313, I did the updates and rebase again. Can you approve pls? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address_in_network,is_ipv4_addressandis_valid_cidripaddressmoduleFixes #5131