Skip to content

Conversation

stefan6419846
Copy link
Collaborator

Closes #3399.

Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.94%. Comparing base (2a91bd4) to head (40577cf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3401   +/-   ##
=======================================
  Coverage   96.94%   96.94%           
=======================================
  Files          55       55           
  Lines        9333     9333           
  Branches     1708     1708           
=======================================
  Hits         9048     9048           
  Misses        170      170           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stefan6419846
Copy link
Collaborator Author

stefan6419846 commented Jul 28, 2025

It seems like jbig2dec is not working as expected on macOS due to building without libpng: https://github.com/Homebrew/homebrew-core/blob/main/Formula/j/jbig2dec.rb#L37

I am not sure if we can reliably detect this without too much overhead, as fully switching from PNG to PBM increases the temporary size for an example image by more than factor 5 (factor 5.4093 for http://cgit.ghostscript.com/cgi-bin/cgit.cgi/tests.git/tree/jbig2/042_1.jb2)

I will not remove installing jbig2dec for now to discuss on how to continue with this before merging.

@stefan6419846 stefan6419846 added the needs-discussion The PR/issue needs more discussion before we can continue label Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion The PR/issue needs more discussion before we can continue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend testing to macOS
1 participant