-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add GNAN model to PyG #10371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add GNAN model to PyG #10371
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10371 +/- ##
==========================================
- Coverage 86.11% 86.01% -0.10%
==========================================
Files 496 504 +8
Lines 33655 35391 +1736
==========================================
+ Hits 28981 30442 +1461
- Misses 4674 4949 +275 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at a high level, but please lets move the example to examples/explain.
Please also add a sentence to examples/README.md to mention, "For examples on explainability with GNNs, see examples/explain."
Then please also update examples/explain/README.md to have a short explanation of what the new example does.
Once thats done I will do a deeper review and can merge
This PR adds the GNAN (https://arxiv.org/pdf/2406.01317) model and a dedicated dataloader to PyG