Skip to content

Conversation

esafak
Copy link
Contributor

@esafak esafak commented Jul 31, 2025

When no discovery plugins are found, the application would crash with a StopIteration. This change catches the StopIteration and raises a RuntimeError with a more informative message.

Fixes #2493

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

When no discovery plugins are found, the application would crash with a StopIteration. This change catches the StopIteration and raises a RuntimeError with a more informative message.

Fixes pypa#2493
@esafak esafak force-pushed the fix/stop-iteration-error branch from 4fcd3ba to 2ec2c4a Compare July 31, 2025 15:01
@gaborbernat gaborbernat enabled auto-merge (squash) July 31, 2025 15:04
@esafak
Copy link
Contributor Author

esafak commented Jul 31, 2025

@esafak a test timeout so it won't automerge

@gaborbernat gaborbernat merged commit 683e5db into pypa:main Jul 31, 2025
81 of 82 checks passed
@esafak esafak deleted the fix/stop-iteration-error branch July 31, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error message with failing discovery
2 participants