config: Do not fail if a warning filter category cannot be imported #13732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra17
force-pushed
the
isra/upstream-no-warning-fail
branch
from
2521fe3 to
1258ad6
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
isra17
force-pushed
the
isra/upstream-no-warning-fail
branch
from
1258ad6 to
3cbbc5e
Compare
nicoddemus
requested changes
Sep 18, 2025
There was a problem hiding this comment.
Thanks @isra17 for the contribution!
Other than the comments I left, please look at the test failure: that test is verifying that we error out if the warnings filter could not be imported, which is exactly what you have changed here. I think you only need to remove that case from the paramatrization.
isra17
force-pushed
the
isra/upstream-no-warning-fail
branch
5 times, most recently
from
7dd2cbb to
195f5e2
Compare
|
The branch is now green and I addressed all your comments. Thanks for your quick review! |
nicoddemus
reviewed
Sep 18, 2025
changelog/13732.improvement.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Do not fail when a warning category cannot be imported. Log a warning instead. | |||
There was a problem hiding this comment.
Suggested change
| Do not fail when a warning category cannot be imported. Log a warning instead. | |
| Previously, when filtering warnings, pytest would fail if the filter referenced a class that could not be imported. Now, this only outputs a message indicating the problem. |
There was a problem hiding this comment.
Could you also apply that change? Thanks!
isra17
force-pushed
the
isra/upstream-no-warning-fail
branch
from
17f7b25 to
950e781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stumbled into an issue using tools like pants that will generate test environment with minimal dependencies. If used with warning filters with categories from third-party library, pytest is going to fail for any test without this third-party. This is unecessary and any workaround in
conftest.pyis impossible due to #13485So this PR change the behavior of failed category import to just log a warning and skip the warning entry.