better check for mxfp8 cuda kernel presence #2933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Short term fix for #2932. If torchao was build without CUDA 10.0 (such as in our CI), ensures that: a. only callsites which actually use the mxfp8 dim1 kernel see the error message. Using NVFP4 no longer hits this error. b. make the error message point to github issue for more info on the workaround (for now, build from souce). Test Plan: 1. hardcode mxfp8 kernel from being built: https://github.com/pytorch/ao/blob/85557135c93d3429320a4a360c0ee9cb49f84a00/setup.py#L641 2. build torchao from source, verify `torchao/prototype` does not have any `.so` files 3. run nvfp4 tests, verify they now pass: `pytest test/prototype/mx_formats/test_nvfp4_tensor.py -s -x` 4. run mxfp8 linear tests, verify the new error message is displayed for dim1 kernel tests: `pytest test/prototype/mx_formats/test_mx_linear.py -s -x -k test_linear_eager_vs_hp` 5. undo the change in (1), rebuild torchao, verify all mx tests pass: `pytest test/prototype/mx_formats/ -s -x` Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2933
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 4 PendingAs of commit c3f0e65 with merge base 8555713 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
danielvegamyhre
approved these changes
Sep 3, 2025
vkuzo
added a commit
that referenced
this pull request
Sep 3, 2025
Summary: Short term fix for #2932. If torchao was build without CUDA 10.0 (such as in our CI), ensures that: a. only callsites which actually use the mxfp8 dim1 kernel see the error message. Using NVFP4 no longer hits this error. b. make the error message point to github issue for more info on the workaround (for now, build from souce). Test Plan: 1. hardcode mxfp8 kernel from being built: https://github.com/pytorch/ao/blob/85557135c93d3429320a4a360c0ee9cb49f84a00/setup.py#L641 2. build torchao from source, verify `torchao/prototype` does not have any `.so` files 3. run nvfp4 tests, verify they now pass: `pytest test/prototype/mx_formats/test_nvfp4_tensor.py -s -x` 4. run mxfp8 linear tests, verify the new error message is displayed for dim1 kernel tests: `pytest test/prototype/mx_formats/test_mx_linear.py -s -x -k test_linear_eager_vs_hp` 5. undo the change in (1), rebuild torchao, verify all mx tests pass: `pytest test/prototype/mx_formats/ -s -x` Reviewers: Subscribers: Tasks: Tags:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Short term fix for #2932. If torchao was built without CUDA 10.0 (such as in our CI), ensures that:
a. only callsites which actually use the mxfp8 dim1 kernel see the error message. Using NVFP4 no longer hits this error.
b. make the error message point to github issue for more info on the workaround (for now, build from souce).
Test Plan:
ao/setup.py
Line 641 in 8555713
torchao/prototypedoes not have any.sofilespytest test/prototype/mx_formats/test_nvfp4_tensor.py -s -xpytest test/prototype/mx_formats/test_mx_linear.py -s -x -k test_linear_eager_vs_hppytest test/prototype/mx_formats/ -s -xReviewers:
Subscribers:
Tasks:
Tags: