Skip to content

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Dec 6, 2022

This re-uses any trace ID that OpenTelemetry supports, or generates a weakly random one based on some request features.

Closes: #1547
Signed-off-by: Hank Donnay [email protected]

@hdonnay hdonnay requested a review from a team as a code owner December 6, 2022 16:03
@hdonnay hdonnay requested review from crozzy and removed request for a team December 6, 2022 16:03
@hdonnay
Copy link
Member Author

hdonnay commented Dec 6, 2022

cc @paulaldridge

@hdonnay hdonnay force-pushed the feature/request-id branch from 2a58ae4 to f26c908 Compare December 6, 2022 16:45
crozzy
crozzy previously approved these changes Dec 8, 2022
Copy link
Collaborator

@crozzy crozzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one comment

This re-uses any trace ID that OpenTelemetry supports, or generates a
random one.

Closes: quay#1547
Signed-off-by: Hank Donnay <[email protected]>
@hdonnay hdonnay force-pushed the feature/request-id branch from c57f214 to a9228d4 Compare December 8, 2022 19:44
@hdonnay hdonnay merged commit a9228d4 into quay:main Dec 9, 2022
@hdonnay hdonnay deleted the feature/request-id branch December 9, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unable to trace requests though logs
2 participants