Skip to content

Conversation

d-kleine
Copy link
Contributor

@d-kleine d-kleine commented Apr 6, 2025

Description

Enhances compatibility with scikit-learn versions 1.4 and above by adjusting parameter handling in the stacking_cv functions (classification, regression)

tests:
pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv
pytest ./mlxtend/regressor/tests/test_stacking_cv_regression.py -sv

Related issues or pull requests

fixes #1117

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@d-kleine d-kleine marked this pull request as ready for review April 6, 2025 14:20
@rasbt
Copy link
Owner

rasbt commented Jun 19, 2025

I completely missed this earlier, thanks for the fix!

Copy link
Owner

@rasbt rasbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Also thanks for adding that toggle for backward compatibility!

@rasbt rasbt merged commit 76439b4 into rasbt:master Jun 19, 2025
2 checks passed
@d-kleine d-kleine deleted the stacking_cv_params branch June 21, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: got an unexpected keyword argument 'fit_params'
2 participants