Skip to content

Conversation

JohnnyCena123
Copy link
Contributor

see here for real time demonstration of the issue

@raysan5
Copy link
Owner

raysan5 commented Sep 21, 2025

@Peter0x44 please, could you take a look? Not sure if ASYNCIFY should be forced, unless it is exclusively target for raylib examples

Also, it's quite confusing to me having examples specific build config inside raylib/src 🤔

@Peter0x44
Copy link
Contributor

this PR isn't forcing ASYNCIFY. the point of the public link options is so that anyone consuming this library from cmake automatically gets those flags applied, so it's okay for any flag that are absolutely REQUIRED 100% of the time to be there, but stuff like ASYNCIFY shouldn't be. I think this PR is correct.

The only thing I'm not completely sure about is if -sEXPORTED_RUNTIME_METHODS=ccall is necessary. I think older emscripten might need it? If so, I'm fine with that.

@raysan5 raysan5 merged commit 085391e into raysan5:master Sep 23, 2025
16 checks passed
@raysan5
Copy link
Owner

raysan5 commented Sep 23, 2025

@JohnnyCena123 @Peter0x44 thanks you very much for the improvement and the review. Afair, -sEXPORTED_RUNTIME_METHODS=ccall was required for some specific cases but maybe emscripten addressed it and it is not required any more...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants