DOC-5378 reactive JSON doc examples #3432
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
mvn formatter:format
target. Don’t submit any formatting related changes.DOC-5378
Reactive examples for the main JSON data type page and the Path sub-page.
All suggestions about style, etc, are welcome, but a couple of things to note are:
toString()
results in tests to simplify them, even though it's not good practice generally to rely ontoString()
being consistent.System.out::println
method reference works naturally. However, there are other places in the published example where the only code visible in adoOnNext()
call is a lambda of the formr -> {System.out.println(r);}
. This looks like it could be replaced by the same method reference. However, it actually happens because there are also asserts in aREMOVE_START
/REMOVE_END
block in the lambda after theprintln
call. It works fine, but if you think it looks like bad style to have this mix of method references and equivalent lambdas, then I'll see what I can do to fix it.