Skip to content

Conversation

andy-stark-redis
Copy link
Contributor

@andy-stark-redis andy-stark-redis commented Sep 3, 2025

Make sure that:

  • You have read the contribution guidelines.
  • You applied code formatting rules using the mvn formatter:format target. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

DOC-5378

Reactive examples for the main JSON data type page and the Path sub-page.

All suggestions about style, etc, are welcome, but a couple of things to note are:

  • I'm following Tisho's comment on the corresponding async JSON PR that it's OK to use toString() results in tests to simplify them, even though it's not good practice generally to rely on toString() being consistent.
  • There are some places in the code where a System.out::println method reference works naturally. However, there are other places in the published example where the only code visible in a doOnNext() call is a lambda of the form r -> {System.out.println(r);}. This looks like it could be replaced by the same method reference. However, it actually happens because there are also asserts in a REMOVE_START/REMOVE_END block in the lambda after the println call. It works fine, but if you think it looks like bad style to have this mix of method references and equivalent lambdas, then I'll see what I can do to fix it.

@andy-stark-redis andy-stark-redis marked this pull request as ready for review September 3, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant