[v23.3.x] Rethrow on unknown exceptions in fetch handler #16691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exceptions from outside the Kafka handler context can bubble up to the catch present in the handler. This seems to be the way some subsystems communicate issues with the requests. There is no current listing of what exceptions subsystems may throw, if/how to recover from these exceptions, or if a fetch should end as a result of the exception. Hence for the time being the fetch impl will revert to the behavior of further bubbling up unknown exceptions to outside of the handler context. (cherry picked from commit a09d160)
piyushredpanda
approved these changes
Feb 27, 2024
This was referenced Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16554
Fixes: #16690,