[v24.2.x] http: Set TCP keepalive #26410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to the base_transport. The method allows us to propagate the keepalive parameters to the underlying TCP socket. Signed-off-by: Evgeny Lazin <[email protected]> (cherry picked from commit e90b086)
The method enables keepalive timer on a socket. Signed-off-by: Evgeny Lazin <[email protected]> (cherry picked from commit 33ab6a2)
The http client can potentially deadlock waiting for data from the connection. If for some reason the connection was dropped and the RST packet wasn't propagated the `recv_some` call in the http client will be blocked for arbitrary amount of time (in some cases the middleware could detect this and send the RST packet later). If the keepalive is enabled we should send the proble after the idle time (set to 5m by this commit). The defaults are chosen to be slightly higher compared to our defaults for Kafka. Signed-off-by: Evgeny Lazin <[email protected]> (cherry picked from commit df82911)
CI test resultstest results on build#67161
|
Lazin
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #26377