[v25.1.x] m/record: added very basic defensive check to prevent crashes #26492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redpada store `model::record_batch` records as opaque bytes. The bytes are materialized to individual `model::record` lazily when iterating over the batch records. During the record materialization record header vector is parsed. The vector size is stored in a variable length encoded integer. If the data in the record buffer are invalid the size may be incorrectly deserialized leading to a very large allocation. Added basic defensive check that compares the requested vector size with the number of bytes left in the buffer. It the size is greater then the exception is thrown as we know that header is never smaller than one byte. Signed-off-by: Michał Maślanka <[email protected]> (cherry picked from commit 7f109db)
|
/ci-repeat 1 |
|
/dt |
CI test resultstest results on build#67524
|
mmaslankaprv
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #26482