Added property to control enablement of __consumer_offsets cache
#26522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
requested review from
dotnwat,
bharathv,
bashtanov,
ztlpn and
joe-redpanda
and removed request for
a team
bashtanov
reviewed
Jun 20, 2025
mmaslankaprv
force-pushed
the
co-batch-cache-option
branch
from
90a4884 to
283213e
Compare
bashtanov
previously approved these changes
Jun 20, 2025
joe-redpanda
previously approved these changes
Jun 20, 2025
bharathv
reviewed
Jun 20, 2025
| "topic. By default cache for consumer offsets topic is disabled. " | ||
| "Changing this property is not recommended in production systems as it " | ||
| "may affect performance. The change is applied only after the restart", | ||
| {.needs_restart = needs_restart::yes, .visibility = visibility::tunable}, |
There was a problem hiding this comment.
not a blocker, just curious why this would need a restart (probably a disruptive action in certain clusters)? It seems like it can be made to pickup for new segments without a restart.
There was a problem hiding this comment.
I would also recommend considering making this needs_restart::no, because to Bharath's point, cloud operators will automatically detect when a needs_restart::yes property is flipped and trigger a rolling restart of a cluster. If the intent here is quick debugability, needs_restart::yes will probably cause headaches.
There was a problem hiding this comment.
It is not so easy, the log property is set when a partition replica is created on the node. We do not change that property dynamically. I wanted to make sure the cluster view is consistent. Therefore i made it to require a restart.
There was a problem hiding this comment.
makes sense. i also didn't expect it to be nuanced like this
CI test resultstest results on build#67663
|
micheleRP
reviewed
Jun 24, 2025
…sets It may sometimes be beneficial for troubleshooting to enable `__consumer_offsets` topic batch cache. The cache is disabled for this topic as it is read only once when applying batches to the stm. The batches written to the topic are usually very small. Skipping storing them in the cache relieve the cache index pressure. Signed-off-by: Michał Maślanka <[email protected]>
Added code handing a configuration property that controls the presence of the cache for the `__consumer_offsets` topic Signed-off-by: Michał Maślanka <[email protected]>
Added a test case that validates if `__consumer_offsets` cache is enabled when cluster property changes. Signed-off-by: Michał Maślanka <[email protected]>
mmaslankaprv
dismissed stale reviews from joe-redpanda and bashtanov
via
094ddcb
mmaslankaprv
force-pushed
the
co-batch-cache-option
branch
from
283213e to
094ddcb
Compare
mmaslankaprv
requested review from
bashtanov,
micheleRP,
WillemKauf,
bharathv and
joe-redpanda
bashtanov
approved these changes
Jun 24, 2025
bharathv
approved these changes
Jun 24, 2025
|
/backport v25.1.x |
|
/backport v24.3.x |
|
Failed to create a backport PR to v24.3.x branch. I tried: |
This was referenced Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may sometimes be required to enabled batch cache for
__consumer_offsetstopic. Added a cluster property that will allow us to change the cache settings.Backports Required
Release Notes
Improvements
__consumer_offsetstopic