AttributeError: 'Module' object has no attribute 'get_marker'

[visko-tm]

System Version: macOS 10.14.2

test_calc.py:

from calc import Calc
class TestCalc(object):
    def test_plus(self):
        assert Calc().plus(2, 3) == 5

    def test_minus(self):
        assert Calc().minus(2, 3) == 5

pytest.ini:

[pytest]
rp_uuid = 2596195c-e886-4fac-a107-5751113b7cc2
rp_endpoint = http://localhost:8080
rp_project = test-poc
rp_launch = regression

Error:

platform darwin -- Python 3.7.2, pytest-4.1.1, py-1.7.0, pluggy-0.8.1
rootdir: /Users/visko/PycharmProjects/test-poc, inifile: pytest.ini
plugins: reportportal-1.0.4
collected 2 items
...
INTERNALERROR>   File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pytest_reportportal/listener.py", line 32, in pytest_runtest_protocol
INTERNALERROR>     self.PyTestService.start_pytest_item(item)
INTERNALERROR>   File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pytest_reportportal/service.py", line 200, in start_pytest_item
INTERNALERROR>     'tags': self._get_item_tags(part),
INTERNALERROR>   File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pytest_reportportal/service.py", line 416, in _get_item_tags
INTERNALERROR>     tags = [k for k in item.keywords if item.get_marker(k) is not None
INTERNALERROR>   File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/pytest_reportportal/service.py", line 416, in <listcomp>
INTERNALERROR>     tags = [k for k in item.keywords if item.get_marker(k) is not None
INTERNALERROR> AttributeError: 'Module' object has no attribute 'get_marker'

The test run (launch) is added to RP, but there are no test cases or results added (total 0). It is supposed to be a very simple basic setup.
Could you please check?

[eg4a]

+1
This happens to me too on Ubuntu 18.04.2 LTS and also on Windows 10.

Any test that I run with the switch '--reportportal' fails on the same issue when it transmits to the report portal end point.

used packages version info:

• reportportal-client version: 3.2.0
• pytest-reportportal version: 1.0.4
• pytest version: 4.2.0

example pytest command :

pytest -vss --reportportal

local workaround that I use to overcome this:

As a local hot-fix , in the service.py file I replaced 'item.get_marker' with 'item.get_closest_marker' on the _get_item_tags method.

Note that from what I saw, the latest revision of the master branch for the service.py file already uses 'item.get_closest_marker'.

Is there an estimate when to expect the next release of a newer version higher than 1.0.4 with this fix?

Thanks :-)

[SazonovDO]

+1
I have this bug:

platform linux -- Python 3.6.7, pytest-4.3.0, py-1.5.2, pluggy-0.8.1
plugins: reportportal-1.0.4
collected 1 item
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/_pytest/main.py", line 210, in wrap_session
INTERNALERROR> session.exitstatus = doit(config, session) or 0
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/_pytest/main.py", line 250, in _main
INTERNALERROR> config.hook.pytest_runtestloop(session=session)
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/hooks.py", line 284, in call
INTERNALERROR> return self._hookexec(self, self.get_hookimpls(), kwargs)
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 68, in _hookexec
INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 62, in
INTERNALERROR> firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/callers.py", line 208, in _multicall
INTERNALERROR> return outcome.get_result()
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/callers.py", line 80, in get_result
INTERNALERROR> raise ex[1].with_traceback(ex[2])
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/callers.py", line 187, in _multicall
INTERNALERROR> res = hook_impl.function(*args)
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/_pytest/main.py", line 271, in pytest_runtestloop
INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/hooks.py", line 284, in call
INTERNALERROR> return self._hookexec(self, self.get_hookimpls(), kwargs)
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 68, in _hookexec
INTERNALERROR> return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/manager.py", line 62, in
INTERNALERROR> firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/callers.py", line 208, in _multicall
INTERNALERROR> return outcome.get_result()
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/callers.py", line 80, in get_result
INTERNALERROR> raise ex[1].with_traceback(ex[2])
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pluggy/callers.py", line 182, in _multicall
INTERNALERROR> next(gen) # first yield
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pytest_reportportal/listener.py", line 32, in pytest_runtest_protocol
INTERNALERROR> self.PyTestService.start_pytest_item(item)
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pytest_reportportal/service.py", line 200, in start_pytest_item
INTERNALERROR> 'tags': self._get_item_tags(part),
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pytest_reportportal/service.py", line 416, in _get_item_tags
INTERNALERROR> tags = [k for k in item.keywords if item.get_marker(k) is not None
INTERNALERROR> File "/usr/local/lib/python3.6/dist-packages/pytest_reportportal/service.py", line 416, in
INTERNALERROR> tags = [k for k in item.keywords if item.get_marker(k) is not None
INTERNALERROR> AttributeError: 'Module' object has no attribute 'get_marker'

Thanks.

+1
This happens to me too on Ubuntu 18.04.2 LTS and also on Windows 10.

Any test that I run with the switch '--reportportal' fails on the same issue when it transmits to the report portal end point.

used packages version info:

• reportportal-client version: 3.2.0
• pytest-reportportal version: 1.0.4
• pytest version: 4.2.0

example pytest command :

pytest -vss --reportportal

local workaround that I use to overcome this:

As a local hot-fix , in the service.py file I replaced 'item.get_marker' with 'item.get_closest_marker' on the _get_item_tags method.

Note that from what I saw, the latest revision of the master branch for the service.py file already uses 'item.get_closest_marker'.

Is there an estimate when to expect the next release of a newer version higher than 1.0.4 with this fix?

Thanks :-)

Local fix helped thanks

[eg4a]

@akropyva-apixio
Happy that the local fix helped :-)
Hopefully a newer version will be released soon.

It fixed this issue and issue with xdist
-e git+git@github.com:reportportal/client-Python.git#egg=reportportal_client
-e git+git@github.com:reportportal/agent-python-pytest.git#egg=pytest_reportportal

[imankovskyi]

should be happening for pytest >= 4.1.0 users
pytest 4.1.0 (2019-01-05)
#4546: Remove Node.get_marker(name) the return value was not usable for more than a existence check.

[DzmitryHumianiuk]

@visko-tm @imankovskyi @akropyva-apixio @eg4a @SazonovDO can we closed it?
fixed?

[eg4a]

Hi @DzmitryHumianiuk ,
The latest version I see for pytest-reportportal is still 1.0.4 , so this issue still reproduces.

Extracting from my initial comment here:

Note that from what I saw, the latest revision of the master branch for the service.py file already uses 'item.get_closest_marker'.

Is there an estimate when to expect the next release of a newer version higher than 1.0.4 with this fix?

[DzmitryHumianiuk]

@filland do we have release job for python agents?
Then should create it, if not.

[filland]

@DzmitryHumianiuk i am working on it

[trew100]

@filland There is already new version?

@imankovskyi how did you resolve this issue with xdist?

[imankovskyi]

issue does not reproduce on 4.0, I used that one

[trew100]

issue does not reproduce on 4.0, I used that one

This issue reproduce for me Pytest == 4.4.1

platform linux -- Python 3.6.8, pytest-4.4.1, py-1.8.0, pluggy-0.9.0
rootdir: /src/tests, inifile: pytest.ini
plugins: reportportal-1.0.4
collected 9 items
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/_pytest/main.py", line 209, in wrap_session
INTERNALERROR>     session.exitstatus = doit(config, session) or 0
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/_pytest/main.py", line 249, in _main
INTERNALERROR>     config.hook.pytest_runtestloop(session=session)
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/hooks.py", line 289, in __call__
INTERNALERROR>     return self._hookexec(self, self.get_hookimpls(), kwargs)
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/manager.py", line 68, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/manager.py", line 62, in <lambda>
INTERNALERROR>     firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/callers.py", line 208, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/callers.py", line 80, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/callers.py", line 187, in _multicall
INTERNALERROR>     res = hook_impl.function(*args)
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/_pytest/main.py", line 270, in pytest_runtestloop
INTERNALERROR>     item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/hooks.py", line 289, in __call__
INTERNALERROR>     return self._hookexec(self, self.get_hookimpls(), kwargs)
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/manager.py", line 68, in _hookexec
INTERNALERROR>     return self._inner_hookexec(hook, methods, kwargs)
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/manager.py", line 62, in <lambda>
INTERNALERROR>     firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/callers.py", line 208, in _multicall
INTERNALERROR>     return outcome.get_result()
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/callers.py", line 80, in get_result
INTERNALERROR>     raise ex[1].with_traceback(ex[2])
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pluggy/callers.py", line 182, in _multicall
INTERNALERROR>     next(gen)  # first yield
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pytest_reportportal/listener.py", line 32, in pytest_runtest_protocol
INTERNALERROR>     self.PyTestService.start_pytest_item(item)
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pytest_reportportal/service.py", line 200, in start_pytest_item
INTERNALERROR>     'tags': self._get_item_tags(part),
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pytest_reportportal/service.py", line 416, in _get_item_tags
INTERNALERROR>     tags = [k for k in item.keywords if item.get_marker(k) is not None
INTERNALERROR>   File "/usr/local/lib/python3.6/site-packages/pytest_reportportal/service.py", line 416, in <listcomp>
INTERNALERROR>     tags = [k for k in item.keywords if item.get_marker(k) is not None
INTERNALERROR> AttributeError: 'Module' object has no attribute 'get_marker'

[vkolgi]

@DzmitryHumianiuk we are still relying on the workaround, can we release the next version soon. If any help needed for the testing do let us know.