Skip to content

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • fix drop table with schema
    example
create schema xxx;
create table xxx.t_nimtable (id int primary key) engine = iceberg;
drop table xxx.t_nimtable;

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chenzl25 chenzl25 requested review from Li0k and xxhZs October 14, 2024 16:29
@github-actions github-actions bot added the type/feature Type: New feature. label Oct 14, 2024
@chenzl25 chenzl25 added this pull request to the merge queue Oct 15, 2024
Merged via the queue into nimtable with commit dca273b Oct 15, 2024
20 of 27 checks passed
@chenzl25 chenzl25 deleted the dylan/fix_drop_table_with_schema branch October 15, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Type: New feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants