Skip to content

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Aug 6, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Support create vector index on functional expression

create index i on items using flat (get_embedding(text)) include(text) with (distance_type = 'l2');

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@wenym1 wenym1 force-pushed the yiming/vector-search-lookup-join branch from b65a7d1 to 617e7de Compare August 19, 2025 07:35
@wenym1 wenym1 force-pushed the yiming/vector-index-on-expr branch 2 times, most recently from 1e982b5 to efe74b6 Compare August 19, 2025 11:15
@wenym1 wenym1 force-pushed the yiming/vector-search-lookup-join branch from 617e7de to acbaf70 Compare August 19, 2025 11:15
@wenym1 wenym1 force-pushed the yiming/vector-index-on-expr branch from efe74b6 to c6cf4c0 Compare August 26, 2025 06:41
@wenym1 wenym1 force-pushed the yiming/vector-search-lookup-join branch from acbaf70 to bfbb898 Compare August 26, 2025 06:41
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenym1 wenym1 force-pushed the yiming/vector-search-lookup-join branch from bfbb898 to 31d95e7 Compare August 29, 2025 17:47
@wenym1 wenym1 force-pushed the yiming/vector-index-on-expr branch from c6cf4c0 to cb6f45b Compare August 29, 2025 17:47
@wenym1 wenym1 changed the base branch from yiming/vector-search-lookup-join to graphite-base/22808 September 1, 2025 18:19
@wenym1 wenym1 force-pushed the graphite-base/22808 branch from 31d95e7 to 986f2f8 Compare September 2, 2025 04:37
@wenym1 wenym1 force-pushed the yiming/vector-index-on-expr branch from cb6f45b to 55898a5 Compare September 2, 2025 04:37
@wenym1 wenym1 changed the base branch from graphite-base/22808 to main September 2, 2025 04:37
@wenym1 wenym1 added this pull request to the merge queue Sep 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2025
@wenym1 wenym1 added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit 6359283 Sep 2, 2025
33 of 34 checks passed
@wenym1 wenym1 deleted the yiming/vector-index-on-expr branch September 2, 2025 08:28
@wenym1 wenym1 added the user-facing-changes Contains changes that are visible to users label Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
block-release-v2.6 type/feature Type: New feature. user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants